linuxdcpp-team team mailing list archive

[noreply@xxxxxxxxxxxxx]

------------------------------------------------------------
revno: 375
committer: Razzloss <razzloss@xxxxxxxxx>
branch nick: master
timestamp: Wed 2010-07-21 01:35:27 +0300
message:
  Remove assert from updateTransfer when dl wasn't found. It happens sometimes that the remove is sent first and then timermanagers tick update comes after. This really isn't an error.
modified:
  linux/transfers.cc


--
lp:linuxdcpp
https://code.launchpad.net/~linuxdcpp-team/linuxdcpp/trunk

Your team LinuxDC++ Team is subscribed to branch lp:linuxdcpp.
To unsubscribe from this branch go to https://code.launchpad.net/~linuxdcpp-team/linuxdcpp/trunk/+edit-subscription

=== modified file 'linux/transfers.cc'
--- linux/transfers.cc	2010-05-30 03:15:23 +0000
+++ linux/transfers.cc	2010-07-20 22:35:27 +0000
@@ -583,10 +583,9 @@
 	GtkTreeIter iter, parent;
 	if (!findTransfer_gui(params["CID"], download, &iter))
 	{
-		int invalid_transfer_CID_not_found = 0;
-		dcassert(invalid_transfer_CID_not_found | !download);	// abort dbg builds when it's a download, otherwise this isn't fatal. 
-		// ConnectionManager seems to send ::Remove before UploadManager sends ::Failed so we can only check for correct behavior with downloads
-	
+		dcdebug("Transfers::updateTransfer, CID not found %s\n", params["CID"].c_str());
+		// Transfer not found. Usually this *shouldn't* happen, but I guess it's possible since tick updates are sent by TimerManager
+		// and removing is handled by dl manager. 
 		return;
 	}