← Back to team overview

linuxdcpp-team team mailing list archive

Re: [Merge] lp:~gpr/dcplusplus/sync into lp:dcplusplus

 

Review: Needs Information
I'm not quite sure I understand why one of the counters uses interprocess::detail and the other shared_ptr::detail - if we're relying on internals, I'd minimise their use.

Also, I do not understand the comment on weak vs strong ordering, could you elaborate please.

Regarding fastcriticalsection, it's a spin lock which is quite appropriate if the sections locked are (very) short (small risk of contention) as OS mutexes add a lot of overhead...
-- 
https://code.launchpad.net/~gpr/dcplusplus/sync/+merge/32912
Your team Dcplusplus-team is subscribed to branch lp:dcplusplus.



References