linuxdcpp-team team mailing list archive

[Big Muscle <617757@xxxxxxxxxxxxxxxxxx>]

I completely removed CriticalSection stuff from StrongDC++ and use only
following typedefs:

typedef boost::recursive_mutex	CriticalSection;
typedef boost::detail::spinlock	FastCriticalSection;
typedef boost::lock_guard<boost::recursive_mutex> Lock;
typedef boost::lock_guard<boost::detail::spinlock> FastLock;

-- 
portable FastCriticalSection implementation
https://bugs.launchpad.net/bugs/617757
You received this bug notification because you are a member of LinuxDC++
Team, which is subscribed to LinuxDC++.

Status in DC++: New
Status in Linux DC++: New

Bug description:
patch attached.
It may have benefits on win32, the old implementation used sleep(1) in "fast" critical section (Thread::yield).
Now Thread::yield seems to be unused, I think it should be removed, it's dangerous. Incorrectly using scheduler's yield may lead to unnecessary cpu consumption.

I tested only unix after patching this.