linuxdcpp-team team mailing list archive

[eMTee <260748@xxxxxxxxxxxxxxxxxx>]

Here's the patch that removes all sources in case of a bad crc32 detected. It makes the sfv check function usable again, still does not cope with the case when the disk write fails (added as todo comment).
I think its worth to add now as is, because its a bit amusig that an option listed in the settings hasn't been working at all for almost 3 years.

** Patch added: "sfvcheck4.patch"
   https://bugs.launchpad.net/dcplusplus/+bug/260748/+attachment/1540892/+files/sfvcheck4.patch

-- 
CRC not verified when segmented downloading finished
https://bugs.launchpad.net/bugs/260748
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.

Status in DC++: Confirmed

Bug description:
When the segmented download has been finished, the "CRC Checked" column in "Finished Downloads" tab displays "No". The Simple File Verification (.sfv) has been downloaded before. (The "enable automatic SFV checking" is turned on.)  I'm using v0.707. (If it's because of the segmented downloading, then maybe that column should or could be removed, because it's useless in that case.)
By the way, why is a column called "CRC Checked" in the "Finished Uploads" tab too? What purpose has it?