linuxdcpp-team team mailing list archive

[Steven Sheehy <654015@xxxxxxxxxxxxxxxxxx>]

Correct me if I'm wrong, but with your patch the behavior between
linuxdcpp and dc++ will differ. DC++ has the following:

%[file] = %[fileFN] = path + filename

So DC++ has only one variable to hold both pathname and filename. While
your patch will separate path and filename into separate variables:

%[file] = %[fileFN] = filename
%[filepath] = %[filePH] = path

DC++ doesn't seem to have %[filePH] and %[filepath] or any other
variable to hold just the path. Of course, the current behavior in
linuxdcpp is wrong since it only contains the filename, but shouldn't we
fix that by adding the path to %[file] and %[fileFN] instead of creating
new variables? Are these other variables common in other clients is that
why you included them?

** Changed in: linuxdcpp
       Status: New => Incomplete

-- 
missing path variable in user commands
https://bugs.launchpad.net/bugs/654015
You received this bug notification because you are a member of LinuxDC++
Team, which is subscribed to LinuxDC++.

Status in Linux DC++: Incomplete

Bug description:
This is in extend of bug #271565 - the commited fix didn't contain the path of the filename.

I added a patch to make this available. It's created on revno 392 and I tested it. The added variable is %[filePH] and aliased as %[filepath]