← Back to team overview

linuxdcpp-team team mailing list archive

[Bug 300728] Re: out of memory if share contains broken directory names

 

Not sure the Win32 implementation of FileFindIter can ever return an empty string but if it does, it does not crash DC++, the result is a simple error message in the log : Error hashing <dirve:\folder\>: cannot the file specified. 
However this message is misleading so if the attached patch satisfy you, it would fix both problem in both platforms.

** Patch added: "invalidfilename.patch"
   https://bugs.launchpad.net/dcplusplus/+bug/300728/+attachment/1686228/+files/invalidfilename.patch

** Changed in: dcplusplus
       Status: New => Confirmed

** Changed in: dcplusplus
   Importance: Undecided => Low

** Patch removed: "invalidfilename.patch"
   https://bugs.launchpad.net/dcplusplus/+bug/300728/+attachment/1686228/+files/invalidfilename.patch

-- 
out of memory if share contains broken directory names
https://bugs.launchpad.net/bugs/300728
You received this bug notification because you are a member of LinuxDC++
Team, which is subscribed to LinuxDC++.

Status in DC++: Confirmed
Status in Linux DC++: Confirmed

Bug description:
linuxdcpp-1.0.2
Filesystem: ext3 utf8
Default hub encoding: CP1251 (Cyrillic)

All works fine until I create on share directory with name in broken encoding.
Linuxdcpp eat all memory (RSS size more than 700 mb) and killed by OOM.