linuxdcpp-team team mailing list archive

[poy <717858@xxxxxxxxxxxxxxxxxx>]

one problem leading to this situation is that users connecting to a
secure port are only considered to be connected after they have
completed their TLS handshake. as a result, users in limbo are never
removed by the functionality controlled by the LoginTImeout setting.

here is a patch to consider users connecting to a TLS port as connected as soon as their socket has been accepted, just as it is for users connecting to a non-TLS port.
in the code, this boils down to calling SocketFactory::completeAccept before initiating the handshake rather than waiting for it to complete.

** Patch added: "Patch"
   https://bugs.launchpad.net/adchpp/+bug/717858/+attachment/2120327/+files/patch.patch

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to ADCH++.
https://bugs.launchpad.net/bugs/717858

Title:
  No timeout when a client connect in NMDC mode.

Status in ADCH++:
  Confirmed

Bug description:
  To reproduce, connect to a adch hub with no adc(s) prefix both hub and
  client will wait for each other to receive a string, the hub for the
  SUP and the client for the $Hello.

  Non of them will close the connection and socket stays connected
  aslong either hub or client restarts.