← Back to team overview

linuxdcpp-team team mailing list archive

[Bug 717858] Re: No timeout when a client connect in NMDC mode.

 

Patch works basic ok but ...

the handle is indeed closed when you use this patch , but the socket
seems not closed, atleast i can see it still after the timeout
disconnects the SID,

to give you a example the guard script has a treshold of 5 events before
any action on a flood is taken , after that it uses the autil.dump(c,
adchpp.AdcCommand_ERROR_BANNED_GENERIC, function(cmd) to kill the new
connect attempts and this removes the socket.

The 5 sockets created due to the threshold do timeout and handles for
them are closed but the sockets stays open.

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to ADCH++.
https://bugs.launchpad.net/bugs/717858

Title:
  No timeout when a client connect in NMDC mode.

Status in ADCH++:
  Fix Committed

Bug description:
  To reproduce, connect to a adch hub with no adc(s) prefix both hub and
  client will wait for each other to receive a string, the hub for the
  SUP and the client for the $Hello.

  Non of them will close the connection and socket stays connected
  aslong either hub or client restarts.


References