linuxdcpp-team team mailing list archive

Thread
Date

[Branch ~dcplusplus-team/dcplusplus/trunk] Rev 2769: possibly fix a crash with tab order

To: LinuxDC++ Team <linuxdcpp-team@xxxxxxxxxxxxxxxxxxx>
From: noreply@xxxxxxxxxxxxx
Date: Wed, 28 Dec 2011 22:43:14 -0000
Reply-to: noreply@xxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

------------------------------------------------------------
revno: 2769
committer: poy <poy@xxxxxxxxxx>
branch nick: trunk
timestamp: Wed 2011-12-28 23:41:03 +0100
message:
  possibly fix a crash with tab order
modified:
  dwt/src/widgets/TabView.cpp


--
lp:dcplusplus
https://code.launchpad.net/~dcplusplus-team/dcplusplus/trunk

Your team Dcplusplus-team is subscribed to branch lp:dcplusplus.
To unsubscribe from this branch go to https://code.launchpad.net/~dcplusplus-team/dcplusplus/trunk/+edit-subscription

=== modified file 'dwt/src/widgets/TabView.cpp'
--- dwt/src/widgets/TabView.cpp	2011-12-23 14:07:18 +0000
+++ dwt/src/widgets/TabView.cpp	2011-12-28 22:41:03 +0000
@@ -445,11 +445,8 @@
 }
 
 void TabView::setTop(ContainerPtr wnd) {
-	auto i = std::find(viewOrder.begin(), viewOrder.end(), wnd);
-	if(i != viewOrder.end() && i != --viewOrder.end()) {
-		viewOrder.erase(i);
-		viewOrder.push_back(wnd);
-	}
+	viewOrder.remove(wnd);
+	viewOrder.push_back(wnd);
 }
 
 int TabView::addIcon(const IconPtr& icon) {