← Back to team overview

linuxdcpp-team team mailing list archive

[Bug 1016907] Re: [Feature Request] Exclude temporary opened files from queue duplicate check

 

Well for vica versa it's not so trivial, though the attached patch
should do it without hurting any existing functionality. It makes an
already complicated part of the code even more cluttered so let's see if
it's accepted or not...

** Patch added: "temporarydupe.patch"
   https://bugs.launchpad.net/dcplusplus/+bug/1016907/+attachment/3202807/+files/temporarydupe.patch

** Changed in: dcplusplus
       Status: Fix Committed => In Progress

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1016907

Title:
  [Feature Request] Exclude temporary opened files from queue duplicate
  check

Status in DC++:
  In Progress

Bug description:
  If I want to check something for whether it's worth downloading for
  me, and use the "View as text" option from the context menu (on a
  plain text file for instance) to achieve this, that file won't be
  added to queue list until it hasn't been opened from the temporary
  location first.

  Here's a simple scenario to introduce this exactly: I use "View as
  text" on a text file, but the user doesn't have free upload slot for
  me. I then mark the folder of which this text file is part of for
  downloading because I assume I want to have it all by default. Once
  the text file would be downloaded and opened from the temporary
  location, I could decide for sure whether I still have interest for
  the newly added items or not. With the current definitions the same
  text file won't appear in the queue's permanent list becasue its hash
  is already available in the list. I need to added it again once the
  file has been downloaded to the temporary location in the first place.

  This also goes the same way vice versa: if it's already in the queue
  marked for permanent download, using the "View as text" on the same
  file won't work either as long as the file is still in the list.

  I would like to ask for changing the queue rules to skip the hash
  check if something is marked for temporary download regardless of
  which location was added first. Of course the same file shouldn't be
  available for neither location twice (or more) afterwards.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1016907/+subscriptions


References