linuxdcpp-team team mailing list archive

[maksis <maksis@xxxxxxxxxxxxxxxxxxxxxx>]

Okay, here's an example:

Another user is sharing a dir "/Video/CD1/" and you perform a search by
using a search term "video cd1". You will receive results from that
other user via NMDC hubs but not via ADC hubs.  This is because in ADC
hubs the client hits the word "video" from the parent directory name,
but it's not removed from the search string list which is being used
when searching from the subdirectories of the dir "Video". So basically
it would still try to match both words "video" and "cd1" when matching
the directory name "CD1" when it should only be matching "cd1".

If you do the changes from AirDC++, you should also receive the ADC
results in the case above.


>From a comment in ShareManager:

"Also, we want to avoid changing StringLists unless we absolutely have
to --> this should only be done if a string has been matched in the
directory name. This new stringlist should also be used in all
descendants, but not the parents..."

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1010996

Title:
  ADC searches are not handled correctly

Status in DC++:
  New
Status in StrongDC++:
  New

Bug description:
  When responding to ADC searches, words found from upper level share
  directories are not removed from the search when searching from
  directories inside them (files in the same directory are handled
  correctly though). Due to this, the client doesn't send all search
  replies that it should.

  The problem has been fixed in AirDC++ 2.30 by removing
  "StringSearch::List* cur" from void
  ShareManager::Directory::search(SearchResultList& aResults, AdcSearch&
  aStrings, StringList::size_type maxResults) and using aStrings.include
  instead.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1010996/+subscriptions