← Back to team overview

linuxdcpp-team team mailing list archive

[Branch ~dcplusplus-team/dcplusplus/trunk] Rev 3042: don't store more rules when renewing port mappings

 

------------------------------------------------------------
revno: 3042
committer: poy <poy@xxxxxxxxxx>
branch nick: trunk
timestamp: Mon 2012-09-10 20:18:29 +0200
message:
  don't store more rules when renewing port mappings
modified:
  dcpp/Mapper.cpp
  dcpp/Mapper.h


--
lp:dcplusplus
https://code.launchpad.net/~dcplusplus-team/dcplusplus/trunk

Your team Dcplusplus-team is subscribed to branch lp:dcplusplus.
To unsubscribe from this branch go to https://code.launchpad.net/~dcplusplus-team/dcplusplus/trunk/+edit-subscription
=== modified file 'dcpp/Mapper.cpp'
--- dcpp/Mapper.cpp	2012-06-18 15:56:01 +0000
+++ dcpp/Mapper.cpp	2012-09-10 18:18:29 +0000
@@ -37,7 +37,7 @@
 	if(!add(port, protocol, description))
 		return false;
 
-	rules.emplace_back(port, protocol);
+	rules.insert(make_pair(port, protocol));
 	return true;
 }
 

=== modified file 'dcpp/Mapper.h'
--- dcpp/Mapper.h	2012-01-13 20:55:20 +0000
+++ dcpp/Mapper.h	2012-09-10 18:18:29 +0000
@@ -20,7 +20,9 @@
 #define DCPLUSPLUS_DCPP_MAPPER_H
 
 #include <string>
-#include <vector>
+#include <set>
+#include <utility>
+
 #include <boost/noncopyable.hpp>
 
 namespace dcpp {
@@ -72,7 +74,7 @@
 	/** remove a port mapping rule. */
 	virtual bool remove(const string& port, const Protocol protocol) = 0;
 
-	std::vector<std::pair<string, Protocol>> rules;
+	std::set<std::pair<string, Protocol>> rules;
 };
 
 } // namespace dcpp