← Back to team overview

linuxdcpp-team team mailing list archive

[Bug 534440] Re: Incorrect encoding of file names, directories ...in the search box.

 

tentative fix in rev 3203; not tested at all.

** Changed in: dcplusplus
       Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/534440

Title:
  Incorrect encoding of file names, directories ...in the search box.

Status in DC++:
  Fix Committed
Status in Linux DC++:
  Confirmed

Bug description:
  The problem with the coding in the search box if the user is connected to a hub such as the external IP address, and I'm on the inside then the function
  ClientManager::getInstance()->findHub(hubIpPort) returns an empty url and a subsequent call to ClientManager::getInstance()->findHubEncoding(url)
  returns the system encoding, and encoding CP1251 hub as a result of the search box in the file names, paths, nicknames does not display correctly.

  void SearchManager:: onData (const uint8_t * buf, size_t aLen, const
  string & remoteIp) {

  ..........

  	string hubIpPort = x.substr(i, j-i);
  	string url = ClientManager::getInstance()->findHub(hubIpPort);                       >>> returns an empty url

  	string encoding = ClientManager::getInstance()->findHubEncoding(url);            >>> does not return the correct encoding hub
  	nick = Text:: toUtf8 (nick, encoding);
  	file = Text:: toUtf8 (file, encoding);
  	hubName = Text:: toUtf8 (hubName, encoding);

  ...........

  	SearchResultPtr sr (new SearchResult (user, type, _slots, freeSlots, size,
  		file, hubName, url, remoteIp, TTHValue (tth), Util:: emptyString));

          fire (SearchManagerListener:: SR (), sr);

  ...........

  }

  Forgive me, I used google translate

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/534440/+subscriptions


References