linuxdcpp-team team mailing list archive

[klondike <franxisco1988@xxxxxxxxx>]

Poy,  the committed patch as is is likely to cause some issues.

Since no check for null is made on free_lua_ref this may crash if it is
used with a null pointer passed by no data being added.

Also on setPluginData you need to get the previous reference and free it
with free_lua_ref or as was done on the attached patch since otherwise
there will be a memory leak on both lua (since the object reference will
never be removed) and C++ (since the structure containing the lua
reference won't be removed).

** Changed in: adchpp
       Status: Fix Committed => New

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to ADCH++.
https://bugs.launchpad.net/bugs/1118699

Title:
  Add typeless object storage in per connection data in lua

Status in ADCH++:
  New

Bug description:
  Using SWIGLUA_REF is possible to store arbitrary lua object references
  for later usage. The propossed implementation should return nil if the
  object is not set and take care of keeping the references.

To manage notifications about this bug go to:
https://bugs.launchpad.net/adchpp/+bug/1118699/+subscriptions