linuxdcpp-team team mailing list archive

[maksis <maksis@xxxxxxxxxxxxxxxxxxxxxx>]

Okay, I found another problem already.

>From the protocol description: "Each filename (including the path to it)
should be matched using case insensitive substring search as follows:
match all AN, remove those that match any NO, and make sure the
extension matches at least one of the EX (if it is present)."


I understand this in a way that also excluded words should be matched from the full path (which isn't the way how it currently works). Here's a new patch that won't continue to sub folders if the directory name contains excluded words.

** Patch added: "ShareManager2.patch"
   https://bugs.launchpad.net/dcplusplus/+bug/1010996/+attachment/3542141/+files/ShareManager2.patch

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1010996

Title:
  ADC searches are not handled correctly

Status in DC++:
  New
Status in StrongDC++:
  New

Bug description:
  When responding to ADC searches, words found from upper level share
  directories are not removed from the search when searching from
  directories inside them (files in the same directory are handled
  correctly though). Due to this, the client doesn't send all search
  replies that it should.

  The problem has been fixed in AirDC++ 2.30 by removing
  "StringSearch::List* cur" from void
  ShareManager::Directory::search(SearchResultList& aResults, AdcSearch&
  aStrings, StringList::size_type maxResults) and using aStrings.include
  instead.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1010996/+subscriptions