linuxdcpp-team team mailing list archive

[noreply@xxxxxxxxxxxxx]

------------------------------------------------------------
revno: 3213
committer: poy <poy@xxxxxxxxxx>
branch nick: trunk
timestamp: Mon 2013-03-04 00:23:53 +0100
message:
  require MinGW-w64
modified:
  Compile.txt
  dcpp/compiler.h
  win32/compiler.h


--
lp:dcplusplus
https://code.launchpad.net/~dcplusplus-team/dcplusplus/trunk

Your team Dcplusplus-team is subscribed to branch lp:dcplusplus.
To unsubscribe from this branch go to https://code.launchpad.net/~dcplusplus-team/dcplusplus/trunk/+edit-subscription

=== modified file 'Compile.txt'
--- Compile.txt	2012-11-06 18:40:25 +0000
+++ Compile.txt	2013-03-03 23:23:53 +0000
@@ -51,9 +51,11 @@
 2. Compiler
 
 	a. MinGW (GCC 4.7 or later):
+	<http://sourceforge.net/projects/mingw-w64/files/>
 	<http://sourceforge.net/projects/mingw/files/>
-	<http://sourceforge.net/projects/mingw-w64/files/>
 
+		We recommend using compilers from the MinGW-w64 project. All you have to do to use one is
+		download it and extract it.
 		Prefer DWARF versions of 32-bit compilers and SEH versions of 64-bit ones. (In short, avoid
 		SJLJ for performance reasons.)
 
@@ -61,9 +63,8 @@
 		mingw-get. Extract it to C:\MinGW and run:
 			mingw-get install gcc g++
 		A graphical installer around mingw-get is also available to facilitate the above.
-
-		The MinGW-w64 project also provides compilers that should be able to grok DC++; in
-		particular, they can be used to build 64-bit binaries (add arch=x64 to the SCons params).
+		Note that building DC++ with MinGW (not MinGW-w64) is not often tested and may lead to
+		stability issues.
 
 		Make sure that MinGW\bin is in your PATH environment variable.
 

=== modified file 'dcpp/compiler.h'
--- dcpp/compiler.h	2013-01-18 21:28:38 +0000
+++ dcpp/compiler.h	2013-03-03 23:23:53 +0000
@@ -22,7 +22,11 @@
 #if defined(__GNUC__)
 #if __GNUC__ < 4 || (__GNUC__ == 4 && __GNUC_MINOR__ < 7)
 #error GCC 4.7 is required
+#endif
 
+#ifndef HAVE_MINGW64
+#error Regular MinGW has stability problems; use a MinGW package from mingw-w64
+// see <https://bugs.launchpad.net/dcplusplus/+bug/1029629> for details
 #endif
 
 #elif defined(_MSC_VER)

=== modified file 'win32/compiler.h'
--- win32/compiler.h	2013-01-18 21:28:38 +0000
+++ win32/compiler.h	2013-03-03 23:23:53 +0000
@@ -21,6 +21,11 @@
 #error GCC 4.7 is required
 #endif
 
+#ifndef HAVE_MINGW64
+#error Regular MinGW has stability problems; use a MinGW package from mingw-w64
+// see <https://bugs.launchpad.net/dcplusplus/+bug/1029629> for details
+#endif
+
 #elif defined(_MSC_VER)
 #if _MSC_VER < 1700 || _MSC_FULL_VER < 170051025
 #error Visual Studio 2012 with the Nov 2012 CTP is required