linuxdcpp-team team mailing list archive

[noreply@xxxxxxxxxxxxx]

------------------------------------------------------------
revno: 29
committer: poy <poy@xxxxxxxxxx>
branch nick: dcpp-plugin-sdk-cpp
timestamp: Mon 2013-06-03 18:30:05 +0200
message:
  encourage pdb distrib
modified:
  packaging/README.txt
  packaging/packager/packager.cpp
  projects/make/Makefile


--
lp:dcpp-plugin-sdk-cpp
https://code.launchpad.net/~dcplusplus-team/dcpp-plugin-sdk-cpp/trunk

Your team Dcplusplus-team is subscribed to branch lp:dcpp-plugin-sdk-cpp.
To unsubscribe from this branch go to https://code.launchpad.net/~dcplusplus-team/dcpp-plugin-sdk-cpp/trunk/+edit-subscription

=== modified file 'packaging/README.txt'
--- packaging/README.txt	2013-06-02 11:17:26 +0000
+++ packaging/README.txt	2013-06-03 16:30:05 +0000
@@ -20,6 +20,7 @@
 
 The <Files> tag is empty; should you want to distribute additional files, include them
 in there within <File> tags (again, more information in the above doc file).
+It is recommended you provide a .pdb file to ease debugging.
 
 When you are done editing this file, rename it to "info.xml", move the relevant files
 to this directory and zip them; rename that .zip to .dcext and you are done!

=== modified file 'packaging/packager/packager.cpp'
--- packaging/packager/packager.cpp	2013-05-23 16:06:31 +0000
+++ packaging/packager/packager.cpp	2013-06-03 16:30:05 +0000
@@ -45,7 +45,8 @@
 		"If you support Windows, include pe-x64 and pe-x86 platforms.\n"
 		"If you support Linux, include elf-x64 and elf-x86 platforms.\n\n"
 		"The <Files> tag is empty; should you want to distribute additional files, include them\n"
-		"in there within <File> tags (again, more information in the above doc file).\n\n"
+		"in there within <File> tags (again, more information in the above doc file).\n"
+		"It is recommended you provide a .pdb file to ease debugging.\n\n"
 		"When you are done editing this file, rename it to \"info.xml\", move the relevant files\n"
 		"to this directory and zip them; rename that .zip to .dcext and you are done!\n"
 		"-->\n\n"
@@ -62,6 +63,8 @@
 		"\t<Plugin Platform=\"pe-x64\">MyPlugin-x64.dll</Plugin>\n"
 		"\t<Plugin Platform=\"pe-x86\">MyPlugin-x86.dll</Plugin>\n"
 		"\t<Files>\n"
+		"\t\t<File Platform=\"pe-x64\">MyPlugin-x64.pdb</File>\n"
+		"\t\t<File Platform=\"pe-x86\">MyPlugin-x86.pdb</File>\n"
 		"\t</Files>\n"
 		"</dcext>\n";
 

=== modified file 'projects/make/Makefile'
--- projects/make/Makefile	2013-05-22 19:19:41 +0000
+++ projects/make/Makefile	2013-06-03 16:30:05 +0000
@@ -66,17 +66,28 @@
 	RMDIR = $(RM) -r $1
 endif
 
+ifeq ($(findstring mingw, $(COMPILER_SPEC)),)
+	PDB =
+else
+	PDB := $(OUTPUT_DIR)/$(TARGET).pdb
+endif
+
 TARGET := $(OUTPUT_DIR)/$(TARGET)$(LIBEXT)
 OBJS := $(addprefix $(OUTPUT_DIR)/, $(OBJS))
 
 PACKAGER = $(OUTPUT_DIR)/packaging/packager$(BINEXT)
 PACK_INFO = ../../packaging/info_generated.xml
 
-all: $(TARGET) $(PACK_INFO)
+all: $(TARGET) $(PDB) $(PACK_INFO)
 
 $(TARGET): $(OBJS)
 	$(CXX) $^ $(LINKFLAGS) $(LINKXXFLAGS) $(OUTPUT_OPTION)
 
+ifneq ($(findstring mingw, $(COMPILER_SPEC)),)
+$(PDB): $(TARGET)
+	strip --only-keep-debug $< $(OUTPUT_OPTION) && strip $<
+endif
+
 $(PACKAGER): $(OUTPUT_DIR)/packaging/packager/packager.o
 	$(CXX) $^ $(subst -shared,,$(LINKFLAGS) $(LINKXXFLAGS)) $(OUTPUT_OPTION)