linuxdcpp-team team mailing list archive
-
linuxdcpp-team team
-
Mailing list archive
-
Message #07038
[Bug 1189975] Re: Forbidden commands in ADC
Added ADCH++ and ADCH++ lan we should provide a way to filter those
whilst the patches roll out.
** Also affects: adchpp-lan
Importance: Undecided
Status: New
** Changed in: adchpp-lan
Assignee: (unassigned) => klondike (klondike)
** Also affects: adchpp
Importance: Undecided
Status: New
** Changed in: adchpp-lan
Importance: Undecided => Critical
--
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1189975
Title:
Forbidden commands in ADC
Status in ADCH++:
New
Status in ADCH++ Lan:
New
Status in DC++:
Fix Committed
Bug description:
When DC++ receives a STA message with code 25, it adds the command in
to the list of forbidden outgoing commands. However, the client
doesn't check that the STA message originates from the hub, so any
other client could send malicious STA messages and prevent DC++ from
sending any outgoing command via the hub. The fix is rather trivial.
I generally dislike the way how code 25 is handled, as DC++ doesn't
notify the user when it blocks a command and neither when an outgoing
command is disregarded right before sending.
To manage notifications about this bug go to:
https://bugs.launchpad.net/adchpp/+bug/1189975/+subscriptions
References