linuxdcpp-team team mailing list archive

[maksis <maksis@xxxxxxxxxxxxxxxxxxxxxx>]

Sorry, some of those really don't apply to DC++. But what you are saying
still isn't true. The info function is called from the hub thread
(handling of SID command) and from the client manager. The crashes that
AirDC users were experiencing happened when their refreshed finished and
they were joining hubs on the same time. What comes to updataCounts,
it's called from the hub thread (handling of INF and SID commands and
various NMDC commands) and from the GUI thread (when the client object
is deleted). It's very unlikely to go wrong with that few async calls
but still possible.

** Changed in: dcplusplus
       Status: Invalid => New

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1194299

Title:
  Threading issues in hub management

Status in DC++:
  New

Bug description:
  AdcHub::info is called from various different threads (timer, refresh,
  hub, GUI) but it's not thread safe. lastInfoMap is unprotected while
  it can be modified from different threads simultaneously. This has
  been fixed in AirDC++ by syncing the info calls from other threads to
  the hub thread.

  Client::updateCounts is another function that shouldn't be called from
  different threads because the hub counts may go wrong. This started to
  cause real problems in AirDC++ when the info calls from TimerManager
  were synced to the hub threads, which caused them to get executed
  asynchronously all the time.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1194299/+subscriptions