← Back to team overview

linuxdcpp-team team mailing list archive

[Bug 1115765] Re: [Feature Request] Exclude certain file extensions

 

neat! i have minor remarks:

1) ItemsEditDlg is missing from the patch too. i can guess it is based
on StringListDlg, which is what i was hoping for. :)

2) for (auto value: container) should usually be for (auto& value:
container) to avoid copies of each value when iterating. the non-ref
version remains acceptable only when a copy is cheap (container of
numbers / pointers).

3) help files you have edited have an ugly BOM introduced in them;
please get rid of it.

4) how about [pattern + "$"] as a regex instead of ["^" + pattern], if
that works? the $ version is made to catch endings.

5) i am having a hard time understanding the min / max file size
concept. is it min / max to include or to exclude? how about "Only share
files whose size is below/higher than X"?

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1115765

Title:
  [Feature Request] Exclude certain file extensions

Status in DC++:
  In Progress

Bug description:
  It would be nice if DC++ can exclude certain file extensions like it
  does for hidden folders and prevent them from being hashed.

  DC++ will often take the file lock to hash incomplete files, which
  happens often when a download from a external program is stalled, and
  causes problems when trying to continue the download.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1115765/+subscriptions


References