linuxdcpp-team team mailing list archive

[poy <1115765@xxxxxxxxxxxxxxxxxx>]

good job overall - more remarks:

3) i still see a BOM in help/settings_sharing_filtering.html.

4) good, so [pattern + "$"] worked. :) the pattern in question should be
escaped though; since this is only for file extensions, just escaping
dots (".") should be enough (eg if one wants to match "tar.bz2").
another possibility is to get the ext with Util::getFileExt then compare
against that.

6) the list splitting from settings on every call to
ShareManager::checkInvalidFileName & ShareManager::checkInvalidPaths
should be optimized - these run once for every file/dir. one could for
ex cache the list in ShareManager and refresh it from settings before
running the directory browsing. similarly, it may be a good idea to
cache the regex / StringMatcher classes (this needs measurements).

7) the min/max size settings should be stored as 64-bit ints so one can
go above 2 GB or so. there is a place in SettingsManager for that
purpose.

8) in UploadFilteringPage::write, only refresh shares when filtering
settings have changed.

9) the 3 handleMod functions in UploadFilteringPage look very similar -
refactor?

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1115765

Title:
  [Feature Request] Exclude certain file extensions

Status in DC++:
  In Progress

Bug description:
  It would be nice if DC++ can exclude certain file extensions like it
  does for hidden folders and prevent them from being hashed.

  DC++ will often take the file lock to hash incomplete files, which
  happens often when a download from a external program is stalled, and
  causes problems when trying to continue the download.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1115765/+subscriptions