linuxdcpp-team team mailing list archive

[Fredrik Ullner <ullner@xxxxxxxxx>]

** Tags added: core

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/655854

Title:
  DC++ accepts relative path for download directories and it can cause
  assertion failure and other problems

Status in DC++:
  New

Bug description:
  #1 finished download directory

  While the current DC++ gui (QueueFrame) can handle only absolute path's starting with <drive>: the lib accepts relative ones for the Default Download Directory setting. If you specify relative or UNC path for default download directory they pass QueueManager::checkTarget and then cause an assertion failure in QueueFrame line 457. 
  After a download finished in a release build UNC path causes a temporary freeze and the file stucks in the unfinished folder. In case of a relative path set for downloads the file will be created relative to the  directory which was current when the DC++ executable started. This can result creation of downloaded files/folders in arbitrary places of the file system.

  #2 unfinished download directory

  The setting accepts relative path as well and there's no any further
  path check in this case. So the actual path where the unfinished files
  created (QueueManager::setFile) will be relative to the directory
  which was current when the DC++ executable started (which is not
  necessarily the program directory). This can result creation of
  Incomplete folders in arbitrary places of the file system and can
  reset unfininished downloads between sessions.

  Thanks Thor for reporting issue #2 which led to further investigation
  of this problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/655854/+subscriptions