← Back to team overview

linuxdcpp-team team mailing list archive

[Bug 1317287] Re: Filelist Download Failure From Specific Usernames

 

Whatever you append to "nul." (mind the dot) it will be discarded. And
getting filelist from user "nul" indeed doesn't work. It throws a couple
of misleading messages in the transferview , the download fails and the
item doesn't disappear from the transferview at all.

Strange because we have a function to fix filenames to save (e.g. for hublists) and IIRC the WIN32 part of that function checks for these reserved words. It doesn't seem to be used in the filelist name formatting though. 
Asterisks, ?, <>, etc.. in the nick probably cause the same problem.

There's two problems here. The error handling of the errors during any
the save of any filelist and the file name formatting itself to avoid
the reported error.

** Changed in: dcplusplus
       Status: New => Confirmed

** Changed in: dcplusplus
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1317287

Title:
  Filelist Download Failure From Specific Usernames

Status in DC++:
  Confirmed

Bug description:
  There is an issue with DC++ when a user chooses a nickname that
  happens to be a Windows Reserved Keyword.  For example, if a user
  chooses a nickname from the following list:

  CON, PRN, AUX, NUL, COM1, COM2, COM3, COM4, COM5, COM6, COM7, COM8,
  COM9, LPT1, LPT2, LPT3, LPT4, LPT5, LPT6, LPT7, LPT8, LPT9 (Reference:
  http://en.wikipedia.org/wiki/Filename#Reserved_characters_and_words)

  a Windows user trying to download the filelist from a user with one of
  these nicks will fail because the filename is in the format of
  *nick*.xml.bz2 (ex. "aux.xml.bz2"), which is disallowed under Windows.
  When DC++ attempts to write the remote user's filelist to disk, the
  download will hang because Windows blocks the writing of this file to
  disk.  There is no error message displayed to the user during this
  process and the reasons for the download to hang are not clearly
  apparent.  The person that is using this nick will have no issues,
  because their filelist is named files.xml.bz2 which is allowed.

  Ideally, the above list would be disallowed as a username so that
  Windows users can download their filelists.  Other clients would need
  to adopt this blacklist as well to be good net citizens towards
  Windows users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1317287/+subscriptions


References