linuxdcpp-team team mailing list archive

[poy <1451223@xxxxxxxxxxxxxxxxxx>]

the main thing to avoid regarding #2 is storing all the data in memory. the HTTP manager defaults to a StringOutputStream, which does precisely that. it's fine for small downloads, but not for a general purpose interface such as this one.
this is made even worse by the final "getString()" call and the copy to a DataArray.

this method can be available as an option, but the safe default would
imo be to not handle any data aggregation in the interface
implementation, but simply send "got data" events and let the plugin
handle that data as it pleases.

i agree with only sending data events to the plugin that requested the
download.

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1451223

Title:
  Support for HTTP file retrieval in DC Plugin

Status in DC++:
  New

Bug description:
  It should be possible to download a file through HTTP with a DC
  Plugin.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1451223/+subscriptions