linuxdcpp-team team mailing list archive

[poy <1451223@xxxxxxxxxxxxxxxxxx>]

looks great!

so you went with more params to the "updated" event. that's nice; much
less convoluted than the stream-that-produces-events i was suggesting.

one point still bothering me: there still is a "getString" call on the "complete" event which nullifies all your efforts. i'm surprised it doesn't even crash when downloading to a file (as the stream would not be a string-stream in that case).
with this new hook style (which i like :)), there is no need to send the whole data once the download is finished: when downloading to a file, the plugin can simply open the file; when downloading via stream, the caller knows where it is storing the data.
so - remove the "data" param of HOOK_DATAACESSOR_HTTP_FILE_NOTIFICATION and this should be perfect. :)

[dat copyright year change that sneaked in tho]

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1451223

Title:
  Support for HTTP file retrieval in DC Plugin

Status in DC++:
  New

Bug description:
  It should be possible to download a file through HTTP with a DC
  Plugin.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1451223/+subscriptions