← Back to team overview

linuxdcpp-team team mailing list archive

[Bug 1307313] Re: ADLSearch can no longer show different files with the same name

 

This patch will solve the issue with at least files. I couldn't get a
similar mechanism to work for directories (basically also changing the
compare function) so that is still broken. Perhaps someone else can take
a look at it?

I didn't notice any performance difference compared to before but people
are welcome to try on large lists...

By the way, the alternative to fixing the comparer is to do as the
ShareManager does; adding numbers to the file, but I'm not sure if
that's something people might want. (I.e. "myfile (1).txt", "myfile
(2).txt" etc.)

** Patch added: "dcpp_adlsearch2.diff"
   https://bugs.launchpad.net/dcplusplus/+bug/1307313/+attachment/4489173/+files/dcpp_adlsearch2.diff

** Changed in: dcplusplus
       Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1307313

Title:
  ADLSearch can no longer show different files with the same name

Status in DC++:
  In Progress

Bug description:
  If user has more than one file with the same name, in different
  directories so virtual names do not come into play, (but different
  TTH) shared ADLSearch can no longer show matches for both files.

  See the attached test case, where ADL search for .txt only displays
  File1.txt and FileC.txt when it should display all three files.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1307313/+subscriptions


References