← Back to team overview

linuxdcpp-team team mailing list archive

[Bug 1656050] Re: Compression errors with zlib 1.2.11

 

** Changed in: airdcpp
       Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1656050

Title:
  Compression errors with zlib 1.2.11

Status in AirDC++:
  Fix Released
Status in ApexDC++:
  Fix Committed
Status in DC++:
  Fix Committed

Bug description:
  After updating zlib to version 1.2.10, transfers randomly fail because
  of compression errors. Such errors happening on uploader's side won't
  reported anywhere, the upload just gets disconnected.

  Based on some debugging with AirDC++, the actual location where the
  error happens in zlib is
  https://github.com/madler/zlib/blob/master/deflate.c#L595

  I'm not sure whether that's a bug in zlib or something intended as
  there are also breaking changes in version 1.2.10:
  https://github.com/madler/zlib/issues/190 (avail_out is not originally
  zero when the call is made)

  Setting compression level at
  https://sourceforge.net/p/dcplusplus/code/ci/default/tree/dcpp/ZUtils.cpp#l59
  to a non-zero value seems to help with avoiding the issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/airdcpp/+bug/1656050/+subscriptions


References