linuxdcpp-team team mailing list archive

[poy <1681153@xxxxxxxxxxxxxxxxxx>]

there were several issues - see rev 87aa1e0fcb086d82243e517310c192a049275582 and the one before for defatils.
essentially, a loop trying to make room for text being added was not finding enough lines to strip off and was therefore running infinitely.
I've also fixed scolling in the process, which I am guessing had never been tested in this particular edge case.

to testers: feel free to play with dwt/test/RichTextBoxTest.cpp - interesting combinations to test these cases:
* REPEATED_TEXT = L"ABC\n"; REPEAT_COUNT = 16384;
* REPEATED_TEXT = L"A\n"; REPEAT_COUNT = 16384;
* REPEATED_TEXT = L"\n"; REPEAT_COUNT = 16384;
* REPEATED_TEXT = L"AAABBB"; REPEAT_COUNT = 16384;

** Changed in: dcplusplus
       Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1681153

Title:
  Sending a lot of empty lines to main chat makes DC++ to hang

Status in DC++:
  Fix Committed

Bug description:
  If i send 15000 empty lines into main chat from another client, DC++
  will hang (sometimes i need to do it twice). When i then restart DC++
  i can see a message '65766: Buffer overflow' from the chat history. So
  if the hubsoft have no line limit you can hang a lot of DC++ clients
  in the hub.

  I'm running DC++ 0.865.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1681153/+subscriptions