linuxdcpp-team team mailing list archive

[maksis <1722364@xxxxxxxxxxxxxxxxxx>]

Yeah, I took the code from AdcHub where it was public for some reason.
Here's a patch for DC++.

** Patch added: "udp.patch"
   https://bugs.launchpad.net/dcplusplus/+bug/1722364/+attachment/4967758/+files/udp.patch

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1722364

Title:
  Invalid ADC commands sent via UDP will crash the app

Status in AirDC++:
  Fix Released
Status in ApexDC++:
  New
Status in DC++:
  New
Status in FlylinkDC++:
  New

Bug description:
  The AdcCommand parsing function will throw ParseException on invalid
  commands:
  https://sourceforge.net/p/dcplusplus/code/ci/default/tree/dcpp/AdcCommand.cpp#l37

  However, SearchManager (UDPServer in AirDC++) won't catch those
  exceptions at all:
  https://sourceforge.net/p/dcplusplus/code/ci/default/tree/dcpp/SearchManager.cpp#l286

  
  As a result, you should be able to crash the app by sending the following raw text to the UDP port: 

  ARES T\n

  (I used https://packetsender.com for testing)

To manage notifications about this bug go to:
https://bugs.launchpad.net/airdcpp/+bug/1722364/+subscriptions