linuxdcpp-team team mailing list archive
-
linuxdcpp-team team
-
Mailing list archive
-
Message #09044
[Bug 1910274] Re: Incomplete trees can be added in hash database
https://sourceforge.net/p/dcplusplus/code/ci/c1c007d312bfbc6fda3136a90294fe738225da15/
fixes this.
** Changed in: dcplusplus
Status: New => Fix Committed
--
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1910274
Title:
Incomplete trees can be added in hash database
Status in DC++:
Fix Committed
Bug description:
Steps to reproduce:
1. Start hashing a large file
2. Exit the application while the hashing is still in progress
3. Open HashIndex.xml and you'll find the file from there
Looks like the application isn't happy with the saved data as it
begins to hash the file again on next startup. I didn't investigate
why that was the case, but I'd say that the current behavior is quite
risky if the code is being modified in future (and the invalid entry
will not get rehashed, which is what happened with AirDC++).
Possibly the application could behave differently if "stop" is true:
https://sourceforge.net/p/dcplusplus/code/ci/default/tree/dcpp/HashManager.cpp#l683
To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1910274/+subscriptions
References