linuxdcpp-team team mailing list archive

[eMTee <2081649@xxxxxxxxxxxxxxxxxx>]

The 2nd answer in <https://stackoverflow.com/questions/48864983/no-
exception-thrown-from-boostasioipaddressfrom-string-on-invalid-addres>
that links <https://wandbox.org/permlink/0wXerng3CYzhAOtT>

The simplest solution seems to be to use the not throwing variant of
from_string(). Inside Boost the throwing variant calls the other variant
anyway so there's no behavioral change.


** Changed in: adchpp
       Status: New => Confirmed

** Changed in: adchpp
   Importance: Undecided => Critical

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to ADCH++.
https://bugs.launchpad.net/bugs/2081649

Title:
  An invalid I4/I6 field received from a client crashes the hub

Status in ADCH++:
  Confirmed

Bug description:
  ADCH++ tries to parse IP fields received from the client from string
  (https://sourceforge.net/p/adchpp/code/ci/default/tree/adchpp/ClientManager.cpp#l353)
  but it won't handle the thrown exceptions for invalid IP addresses in
  any way. The crash can be triggered by sending a malformed I4 param
  (e.g. 999.999.999.999) to the hub.

  Fixed in commit https://github.com/maksis/adchpp-
  hbri/commit/d24e8972f9d1f2268fb8b1dec0dc3676f62fad17 of my HBRI fork.

To manage notifications about this bug go to:
https://bugs.launchpad.net/adchpp/+bug/2081649/+subscriptions