linuxdcpp-team team mailing list archive

[eMTee <2045404@xxxxxxxxxxxxxxxxxx>]

Fixed in DC++ 0.882.

** Changed in: dcplusplus
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/2045404

Title:
  .pot generation is broken since a recent dcplusplus.rc change

Status in DC++:
  Fix Released

Bug description:
  An item is needed to remove from $SOURCES used in https://sourceforge.net/p/dcplusplus/code/ci/7cfc388170e408c621aa100f8f3563815f46566d/tree/SConstruct#l359 and on for "Extracting messages to $TARGET from $SOURCES". 
  $SOURCES is a list of files to build and supposedly coming directly from SCons, a list of .h and .cpp files reside in dcpp and win32 folders with the exception of DCPlusPlus.o (DCPlusPlus.rc's generated object file). This action where $SOURCES passed as a parameter actually gets the strings from source files in dcpp and win32 for .pot generation. 
  I don't know how it worked before, maybe it's something caused by a change in Scons versions along the way that this .o file (and not the .rc one) is in the list. Or maybe it has been like that always so the .o file has been left on the list, as supposedly there's no strings with the gettext syntax to be found in an .o file. 
  Until now. Since .rc has changed recently with the new icons, gettext finds one item, a garbage string with zeros and whatever multibyte contents in the .o file and makes one garbage item in the .pot file coming from DCPlusPlus.o. 
  This rogue string then appears in the transalting interface but more annoyingly breaks the .po/.mo generation as well and has to be removed by hand when the build of the distro stops with an error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/2045404/+subscriptions