livepatch-charmers team mailing list archive

[Adam Collard <adam.collard@xxxxxxxxxxxxx>]

> Is this to work around a particular problem? The bundled version is going to
> be much more recent than this.

Yes, the problem we hit was that we had a version of the charm which had many versions of charm-helpers in its wheelhouse/ . In combination with layer-basic's code to install *everything* in the wheelhouse/ found from an unordered glob.glob() meant that on some units, charm-helpers-0.10 was being installed, which breaks the install hook (due to missing host.is_container()).

Whilst the issue of having multiple charm-helpers in the wheelhouse/ needs solving independently, the code in this charm *does* require charm-helpers >= 0.11, and as such I think it should state that.
-- 
https://code.launchpad.net/~adam-collard/canonical-livepatch-charm/+git/canonical-livepatch-charm/+merge/348176
Your team Livepatch charm developers is requested to review the proposed merge of ~adam-collard/canonical-livepatch-charm:wheelhouse into canonical-livepatch-charm:master.