livepatch-charmers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Review: Approve

Looks good. The livepatch-proxy.configured flag name change is only partially complete, so this either needs to be finished or reverted. The flag names are inconsistent no matter which way you swing ;)

Diff comments:

> diff --git a/reactive/canonical_livepatch.py b/reactive/canonical_livepatch.py
> index 7c0b559..0a0d154 100644
> --- a/reactive/canonical_livepatch.py
> +++ b/reactive/canonical_livepatch.py
> @@ -208,7 +210,7 @@ def proxy_configure():
>  
>  
>  @when('snap.installed.canonical-livepatch')
> -@when('livepatch-proxy.configured')
> +@when('livepatch.proxy.configured')

proxy_configure is still setting the livepatch-proxy.configured flag, so if you change it here you need to change it there too.

>  @when_not('canonical-livepatch.connected')
>  def canonical_livepatch_connect():
>      # So if we've just installed snapd on a trusty system, we will not be on


-- 
https://code.launchpad.net/~barryprice/canonical-livepatch-charm/+git/canonical-livepatch-charm/+merge/348326
Your team Livepatch charm developers is subscribed to branch canonical-livepatch-charm:master.