livepatch-charmers team mailing list archive

Thread
Date

Re: [Merge] ~barryprice/canonical-livepatch-charm/+git/canonical-livepatch-charm:master into canonical-livepatch-charm:master

To: mp+348671@xxxxxxxxxxxxxxxxxx
From: Paul Gear <paul.gear@xxxxxxxxxxxxx>
Date: Fri, 29 Jun 2018 02:39:18 -0000
In-reply-to: <153020126126.13319.15139691064376651293.launchpad@ackee.canonical.com>
Reply-to: mp+348671@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

LGTM, but if you have a plan to switch to importing modules into separate namespaces, then now's the time to do it.  At least time.sleep and yaml.load are trivial to implement now.
-- 
https://code.launchpad.net/~barryprice/canonical-livepatch-charm/+git/canonical-livepatch-charm/+merge/348671
Your team Livepatch charm developers is subscribed to branch canonical-livepatch-charm:master.

References

[Merge] ~barryprice/canonical-livepatch-charm/+git/canonical-livepatch-charm:master into canonical-livepatch-charm:master
From: Barry Price, 2018-06-28