← Back to team overview

lttng team mailing list archive

  1. lttng team
  2. Mailing list archive
  3. Message #07681

[Bug 1990232] Re: ubuntu_lttng_smoke_test failed with module build on J-5.15.0-49.55

  Thread Previous • Date Previous • • Thread Next 
This bug was fixed in the package lttng-modules -
2.12.5-1ubuntu2~20.04.4

---------------
lttng-modules (2.12.5-1ubuntu2~20.04.4) focal; urgency=medium

  * Backport fixes to handle kfree_skb_reason() in 5.15.y (LP: #1990232)
    - d/p/0010-compat-v5.15.58-add-kfree-skb-reason.patch
    - d/p/0011-compat-v5.15.58-rename-SKB-DROP-REASON-SOCKET-FILTER.patch
    - d/p/0012-compat-v5.15.58-introduce-kfree-skb-reason.patch

 -- Stefan Bader <stefan.bader@xxxxxxxxxxxxx>  Wed, 21 Sep 2022 16:32:14
+0200

** Changed in: lttng-modules (Ubuntu Focal)
       Status: Fix Committed => Fix Released

** Changed in: lttng-modules (Ubuntu Jammy)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
LTTng, which is subscribed to lttng-modules in Ubuntu.
Matching subscriptions: lttng-modules-bugs
https://bugs.launchpad.net/bugs/1990232

Title:
  ubuntu_lttng_smoke_test failed with module build on J-5.15.0-49.55

Status in ubuntu-kernel-tests:
  New
Status in lttng-modules package in Ubuntu:
  Fix Released
Status in lttng-modules source package in Focal:
  Fix Released
Status in lttng-modules source package in Jammy:
  Fix Released

Bug description:
  [SRU Justification]

  Impact: Upstream stable backported a patch from 5.17 into 5.15.58
  which allows to pass a reason message when dropping network SKBs. This
  however requires some adaptions to lttng-modules (again) to handle the
  modified interface.

  Fix: Picking 3 patches from upstream lttng-modules which handle the
  changed interface as well as add the required code to enable that
  change for 5.15 stable kernels starting with subversion 58.

  Testcase: Compiling for the latest 5.15 Ubuntu kernels fails with
  below messages. Once the 3 fixes are applied this succeeds (and the
  previous kernel also still works).

  Regression potential: Probes related to dropping SKBs might show
  issues. But also tooling which uses these might get surprised by
  suddenly seeing reason messages.

  ---

  Issue found on Jammy 5.15.0-49.55

  Module build log:
   Running 'cat /var/lib/dkms/lttng-modules/*/build/make.log'
   DKMS make.log for lttng-modules-2.13.1 for kernel 5.15.0-49-generic (x86_64)
   Tue Sep 20 04:39:58 UTC 2022
   make: Entering directory '/usr/src/linux-headers-5.15.0-49-generic'
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lttng-ring-buffer-client-discard.o
   /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/Kbuild:62: File ./arch/x86/kvm/lapic.h not found. Probe "kvm" x86-specific is disabled. Use full kernel source tree to enable it.
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/tests/probes/lttng-test.o
   /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/Kbuild:166: Files ./fs/btrfs/*.h not found. Probe "btrfs" is disabled. Use full kernel source tree to enable it.
   /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/Kbuild:177: Files ./fs/ext4/*.h not found. Probe "ext4" is disabled. Use full kernel source tree to enable it.
   /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/Kbuild:206: File ./drivers/base/regmap/trace.h not found. Probe "regmap" is disabled. Need Linux 4.1+ kernel source tree to enable it.
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lib/ringbuffer/ring_buffer_backend.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-sched.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/tests/clock-plugin/lttng-clock-plugin-test.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lttng-ring-buffer-client-overwrite.o
     LD [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/tests/lttng-test.o
     LD [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/tests/lttng-clock-plugin-test.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lttng-ring-buffer-metadata-client.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lib/ringbuffer/ring_buffer_frontend.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-irq.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lttng-ring-buffer-client-mmap-discard.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lttng-ring-buffer-client-mmap-overwrite.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-timer.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lib/ringbuffer/ring_buffer_iterator.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lib/ringbuffer/ring_buffer_vfs.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lib/ringbuffer/ring_buffer_splice.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-kmem.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lib/ringbuffer/ring_buffer_mmap.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lib/prio_heap/lttng_prio_heap.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lib/../wrapper/splice.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lib/counter/counter.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-module.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-power.o
     LD [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lib/lttng-lib-ring-buffer.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-statedump.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-9p.o
     LD [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lib/lttng-counter.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lttng-ring-buffer-metadata-mmap-client.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-i2c.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-kvm.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-x86-irq-vectors.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-x86-exceptions.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-signal.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-block.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-napi.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-skb.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-net.o
   In file included from /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/../../include/lttng/define_trace.h:87,
                    from /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/../../include/instrumentation/events/skb.h:59,
                    from /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-skb.c:29:
   /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/../../include/lttng/tracepoint-event-impl.h:133:6: error: conflicting types for ‘trace_kfree_skb’; have ‘void(struct sk_buff *, void *)’
     133 | void trace_##_name(_proto);
         |      ^~~~~~
   /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/../../include/lttng/tracepoint-event-impl.h:45:9: note: in expansion of macro ‘LTTNG_TRACEPOINT_EVENT_INSTANCE_MAP’
      45 |         LTTNG_TRACEPOINT_EVENT_INSTANCE_MAP(map, name, map, PARAMS(proto), PARAMS(args))
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/../../include/instrumentation/events/skb.h:16:1: note: in expansion of macro ‘LTTNG_TRACEPOINT_EVENT_MAP’
      16 | LTTNG_TRACEPOINT_EVENT_MAP(kfree_skb,
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from ./include/trace/events/skb.h:10,
                    from /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-skb.c:18:
   ./include/linux/tracepoint.h:245:28: note: previous definition of ‘trace_kfree_skb’ with type ‘void(struct sk_buff *, void *, enum skb_drop_reason)’
     245 |         static inline void trace_##name(proto)                          \
         |                            ^~~~~~
   ./include/linux/tracepoint.h:419:9: note: in expansion of macro ‘__DECLARE_TRACE’
     419 |         __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
         |         ^~~~~~~~~~~~~~~
   ./include/linux/tracepoint.h:553:9: note: in expansion of macro ‘DECLARE_TRACE’
     553 |         DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
         |         ^~~~~~~~~~~~~
   ./include/trace/events/skb.h:44:1: note: in expansion of macro ‘TRACE_EVENT’
      44 | TRACE_EVENT(kfree_skb,
         | ^~~~~~~~~~~
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-sock.o
   make[3]: *** [scripts/Makefile.build:297: /var/lib/dkms/lttng-modules/2.13.1/build/src/probes/lttng-probe-skb.o] Error 1
   make[3]: *** Waiting for unfinished jobs....
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lttng-ring-buffer-event-notifier-client.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lttng-counter-client-percpu-32-modular.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lttng-counter-client-percpu-64-modular.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lttng-clock.o
     CC [M]  /var/lib/dkms/lttng-modules/2.13.1/build/src/lib/msgpack/msgpack.o
   make[2]: *** [scripts/Makefile.build:560: /var/lib/dkms/lttng-modules/2.13.1/build/src/probes] Error 2
   make[2]: *** Waiting for unfinished jobs....
   make[1]: *** [scripts/Makefile.build:560: /var/lib/dkms/lttng-modules/2.13.1/build/src] Error 2
   make: *** [Makefile:1900: /var/lib/dkms/lttng-modules/2.13.1/build] Error 2
   make: Leaving directory '/usr/src/linux-headers-5.15.0-49-generic'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1990232/+subscriptions

References

  Thread Previous • Date Previous • • Thread Next