← Back to team overview

maas-devel team mailing list archive

Re: commit messages

 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/30/2012 7:56 PM, Gavin Panella wrote:
> On 30 August 2012 16:29, Scott Moser <smoser@xxxxxxxxxx> wrote:
>> I'm really baffled as to why you wouldn't want that in the
>> commit message.
> 
> Perhaps I worry too much about the effort of addressing the
> log-reader audience (e.g. a future audience without the context of
> the moment). I also rarely look at the logs. I instead subscribe to
> the branch, so I keep up to date by scanning review and revision
> mail. I'm involved in directly shaping MAAS so this is appropriate
> for me.
> 
> Someone downstream can either subscribe to the branch for revision 
> information, or read logs. I can see that, here, having a
> distilled summary of the merge would be of greater worth.
> 
> I've talked myself into it now: I'll do longer commit messages,
> with the pithy git-style one-liner at the top. If I get fed up with
> it I'll get back to you and the list, to compare my pain with the
> benefit it's giving you and those who are largely downstream of
> lp:maas.
> 

You also have 'bzr log --line' for the short summaries as well. So the
single-line summary is useful in bzr.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iEYEARECAAYFAlA/t00ACgkQJdeBCYSNAAO30ACgpOygz7jWW5pMyqEUlOxQ7//x
wCsAoJ0lg4a4Q7pyo/+mue9UoKKjKsfx
=GJID
-----END PGP SIGNATURE-----


References