maas-devel team mailing list archive

[John Arbash Meinel <john@xxxxxxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/10/2012 1:30 PM, Gavin Panella wrote:
> On 10 October 2012 10:23, Martin Packman
> <martin.packman@xxxxxxxxxxxxx> wrote:
>>> - couldn't use tags to deploy with juju. Got an error "no such
>>> tag": https://bugs.launchpad.net/maas/+bug/1064734
>> 
>> This is painful as juju 0.6 was released yesterday, but we need
>> the fix there. Short story, my initial code version involved a
>> set and used ",".join when passing on to api, then simplified to
>> just pass a string straight through, then in response to review
>> re-added the set logic to pre-validate tags but missed adapting
>> the api back again. So MaaS is passed the stringified set rather
>> than the original tag string. The provider needs some better unit
>> test coverage for constraint/api interactions.
> 
> It's ugly as hell, but is it worth adding a temporary workaround
> to extract tags from a string of the form "set([...])"?
> 

Well, it certainly is something that means you can fix it in MAAS
rather than in Juju...

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (Cygwin)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iEYEARECAAYFAlB1VD0ACgkQJdeBCYSNAAOiTACdFcal7LHanxwNVFMJIVIiJddA
SJ4Anjl5eDVk1G28xeY4/Iv3xFI/i++u
=vFvC
-----END PGP SIGNATURE-----