← Back to team overview

maas-devel team mailing list archive

Re: Integrated your code into lp:~trapnine/maas/ha_rack_details

 

I think Jeff is correct in keeping the zone. Zone is a physical zone and a
rack controller must exists in that physical zone. But overall it is
looking really good.

On Tue, Feb 16, 2016 at 5:47 AM, Richard McCartney <
richard.mccartney@xxxxxxxxxxxxx> wrote:

> Hey Jeff,
>
> I’ve pulled down your working branch for MAAS HA, you need to run make
> styles as your not using the new updated styles at all and it should fix
> the issue with the tree & table styles. Regarding the information summary
> this has been finalised in our design catchups and should look like the
> following screenshot I have attached. Apart from that everything else so
> far looks correct in your working branch.
>
>
>
> Regards,
>
> *Richard McCartney*
> Front End Web Developer
> Cloud & Web Team
>
> ubuntu.com | canonical.com
>
> richard.mccartney@xxxxxxxxxxxxx
> +44 (0) 792 183 4505
>
> On 16 Feb 2016, at 03:08, Jeff Jones <jeff.jones@xxxxxxxxxxxxx> wrote:
>
> Hi Rich,
>
> I've attached a shot of a working first rev of the controller details page.
> This includes all your code from  lp:~ricgard/maas/rack-details.
>
> Questions:
>
> 1) Some of the summary items in your HTML differ from the node details
> page and Carla's mock. (no zone, OS, status on left, DHCP on right,
> etc) I've moved them around a bit to make them more consistent with
> both. Thoughts?
>
> 2) Does the tree look right to you? I integrated all your CSS changes,
> etc, and that part of the HTML is rote from your branch. You can look
> at the HTML in my branch at lp:~trapnine/maas/ha_rack_details  - feel
> free to submit any HTML changes there.
>
> Thanks,
> Jeff
>
> P.S. Has the original sketch from Carla been updated?
> (https://drive.google.com/file/d/0BxXAS-9xXKkLZHhWMEJ6OE55NHc/view)
> <controller_details.png>
>
>
>

PNG image


Follow ups

References