← Back to team overview

mactel-support team mailing list archive

[Bug 596641] Re: mbp-nvidia-bl: adding support for MacBook Pro 7, 1

 

@Panard:
(1) What is your machine? MacBook 7,1 or MacBookPro 7,1 ? The patch is named MBP, but adds support for an MB.

(2) The max_level parameter is used to compute a mask to only overwrite
the necessary least significant bits of an (undocumented) register.
Thus, it should preferably be a power of 2 minus 1, e.g., Ox3ff
(hexadecimal). If you use other values, the mask will be the set of
least significant bits required to represent this value. But you cannot
set higher values than specified, which is mainly useful on Sony
machines.

(3) Higher values shouldn't destroy your machine. But please note that
there's no quarantee. There's isn't even an official documentation
available. However, I'd highly appreciate a value as exact as possible.

(4) You can try to figure it out like this: Set max_value to some large value, e.g., 0xffffff (2^24-1) and increase brightness until you observe no change in visible brightness anymore. This should be more or less around a power of 2 depending on the method you choose. Most precisely is:
$ echo <value> | sudo tee /sys/class/backlight/nvidia_backlight/brightness

(5) Please also disable any hacks in your xorg.conf regarding display
backlight.

Thanks & ciao,
Mario

-- 
mbp-nvidia-bl: adding support for MacBook Pro 7,1
https://bugs.launchpad.net/bugs/596641
You received this bug notification because you are a member of Mactel
Support, which is the registrant for Mactel Support.

Status in Mactel Support: New

Bug description:

MacBook Pro 7,1 has a nvidia chipset (MCP89 / graphics: Geforce 320 M)

I tried to add the following lines into mbp_nvidia_bl.c:

        {
                .callback       = mbp_dmi_match,
                .ident          = "MacBookPro 7,1",
                .matches        = {
                        DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
                        DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro7,1"),
                },
                .driver_data    = (void *)&nvidia_chipset_data,
        },


At bootup, 
$ cat /sys/class/backlight/mbp_backlight/brightness
15

but,
$ echo 3 >  /sys/class/backlight/mbp_backlight/brightness 
does nothing on the brightness, except that
$ cat /sys/class/backlight/mbp_backlight/brightness
3

If you need some command line outputs, I can provide them.

Thanks





References