← Back to team overview

magentoerpconnect-community team mailing list archive

base_sale_multichannels dependencies

 

Hi community,

I need your thoughts.

Some times ago I introduced a simple feature on base_sale_multichannels.

------------------------------------------------------------
revno: 5454
committer: Guewen Baconnier @ CampToCamp <guewen.baconnier@xxxxxxxxxxxxxx>
branch nick: extra-6.0
timestamp: Thu 2011-07-14 16:37:48 +0200
message:
  [IMP] base_sale_multichannels : options on Delivery Carriers to not export
the shippings until they have a tracking number (export always by default,
active the option to wait for a tracking number)


Here is the context of the change :
For example in the case of Magento, when you export a shipping, the tracking
number is exported at the same time.
But in some cases, you don't have the tracking number directly on your
packing when you confirm it, the carrier will give you the tracking numbers
and a batch will write it on the packings.

The idea was that, per carrier, you can choose if a packing without tracking
number is exported to Magento or not.


I missed that the base_sale_multichannels does not depend on 'delivery'
module and my feature add a dependency on it (and so on purchase which is a
dependency of delivery).
At the moment, I added the module in the depends to not break installs, but
I'm not convinced of the pertinence to add dependencies on these 2 modules
just for a such small feature.

In the other hand, this can be useful for other use cases than magento
because it adds more control to the export of the shippings. (but as I only
use base_sale_multichannels, I do not realize really).

So we have 2 solutions :
 - keep this feature at base_sale_multichannels and take on the delivery and
purchase dependencies
 - move this feature to magentoerpconnect. In this case it'll need a little
refactoring of base_sale_multichannels/sale/sale_shop.export_shipping to
afford to do so from magentoerpconnect.

So ?



-- 
Guewen Baconnier

Business Developer
Business Solutions
Camptocamp SA
PSE A, CH-1015 Lausanne

http://openerp.camptocamp.com/

Phone: +41 21 619 10 39
Office: +41 21 619 10 10
Fax: +41 21 619 10 00
Email: guewen.baconnier@xxxxxxxxxxxxxx

Follow ups