mahara-contributors team mailing list archive

[François Marier <francois@xxxxxxxxxx>]

Hi Lester,

I'm very sorry for the time it took to respond to you. Being more open
to other databases is certainly something we'd like to improve on in the
future, so you're doing some really good work there.

Now, the core firebird drivers should no longer be necessary on the
master branch of Mahara since I upgraded yesterday to the latest version
of adodb. I don't know if that's the version of Mahara you are basing
your work on, but that's where we'd put your changes once they are ready
to be merged.

Another thing that would help us quite a bit is if you could, instead of
attaching the whole codebase, provide a patch series for your changes.
That way, we can see exactly what your changes are.

Moodle has good documentation on how to create patches:

  http://docs.moodle.org/en/Development:How_to_create_a_patch

Cheers,
Francois

-- 
Firebird support development
https://bugs.launchpad.net/bugs/572189
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: New

Bug description:
Attached are a pair of drivers to add Firebird as an option on the supported databases. Class goes to xmldb library, and the adodb driver replaces the one currently provided.

The next step on this exercise is to work out how to handle wrapping of field names with double quotes. The normal practice has been to use 'backtick' as a hook to identify both field and table names that need processing. This is then replaced or removed as required before the SQL is run. This would - I think - tidy up a problem I am seeing currently in the code base where some fields have had double quotes added in the scripts, or bodge case statements adjust things for MySQL or Postgres .... A generic fix would allow the availability of other databases to be expanded? And I am happy to look at handling that.