← Back to team overview

mahara-contributors team mailing list archive

[Bug 591584] Re: View editor drag and drop broken on iPhone/iPad

 

** Patch added: "Slightly revised patch"
   http://launchpadlibrarian.net/52146737/iphone_v2.patch

** Changed in: mahara
       Status: Triaged => Fix Committed

-- 
View editor drag and drop broken on iPhone/iPad
https://bugs.launchpad.net/bugs/591584
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: Fix Committed

Bug description:
>From http://mahara.org/interaction/forum/topic.php?id=1913 :

Hi All,

As we are planning a project that uses Mahara with iPad and iPhone in class, we ran in to a small problem of the drag-and-drop not working in creating and editing views. We solved it by modifing the views.js file to treat the devices as ie6. We post it here to see whether there is better way to solve it and possibly help others who ran into the same problem and want a quick fix :-)

Many Thanks

James

 

P.S. The patch script (to patch against js/views.js file in version 1.2.4 :

78c78,86
<         }
---
>         } else {
>             // Unhide the radio button if the browser is iPhone, IPad or IPod
>             if ((navigator.userAgent.match(/iPhone/i)) || (navigator.userAgent.match(/iPod/i)) || (navigator.userAgent.match(/iPad/i))) {
>                     forEach(getElementsByTagAndClassName('input', 'blocktype-radio', 'top-pane'), function(i) {
>                     setNodeAttribute(i, 'style', 'display:inline');
>                 });
>             }
>
>         }
1116a1125,1129
>
>     // Whether the brower is iPhone, IPad or IPod
>     if ((navigator.userAgent.match(/iPhone/i)) || (navigator.userAgent.match(/iPod/i)) || (navigator.userAgent.match(/iPad/i))) {
>             this.isIE6 = true;
>     }





References