mahara-contributors team mailing list archive

[Andrew Robert Nicols <617187@xxxxxxxxxxxxxxxxxx>]

Hi John,

Thanks for the bug report and the patch.  Rather than simply changing the version in the language string, I've passed the required  version of php to get_string in the ensure_sanity() function of lib/mahara.php.  This has the advantage that it can't get out of sync again as we're testing the same version number that we're passing.  If you're interested, it commit 
72d12ea829798e8d7f3f446a9070dc4f32fd8ecd of master.

This change won't fix non-english langauge files as these are
distributed seperately.

** Changed in: mahara
   Importance: Undecided => Low

** Changed in: mahara
       Status: New => Confirmed

** Changed in: mahara
    Milestone: None => 1.3.0

** Changed in: mahara
     Assignee: (unassigned) => Andrew Robert Nicols (dobedobedoh)

** Changed in: mahara
       Status: Confirmed => Fix Committed

-- 
lang string 'phpversion' contains incorrect version of php
https://bugs.launchpad.net/bugs/617187
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: Fix Committed

Bug description:
In the daily build of Mahara the ensure_sanity function checks that the current PHP version is 5.2 or greater.

If it is not the phpversion string is displayed, which still indicates PHP 5.1.2 or greater.