← Back to team overview

mahara-contributors team mailing list archive

[Bug 619168] Re: newviews blocktype shows grouphomepage views

 

So we want to remove grouphomepage views from the newviews block type (where they shouldn't be displayed).
newviews/lib.php uses View::view_search()

However, the grouphomepage views should be visible to group admins on
view/groupviews.php for editting etc and view/groupviews.php also uses
View::view_search()

Since they're only ever shown to admins, it doesn't really matter if a
grouphomepage view is shown in the newviews blocktype.

I've also pushed a fix to ensure that deleted group views are not
displayed; and a fix to display_title when using grouphomepages.

-- 
newviews blocktype shows grouphomepage views
https://bugs.launchpad.net/bugs/619168
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: New

Bug description:
If you create a new group, and then delete it, it's views are not deleted.
As a result, they are still shown on the newviews blocktype, and trying to view that view results in various errors because the owner does not exist.

Not sure whether the view should be deleted, or whether the newviews blocktype needs to ignore deleted groups.





References