mahara-contributors team mailing list archive

[Andrew Robert Nicols <619284@xxxxxxxxxxxxxxxxxx>]

Added a function View->is_themeable() which checks whether the current
theme type is not in an array.

If other view types are added in the future which don't respect theming,
then they'll need adding to the array in View->is_themeable().

** Changed in: mahara
       Status: Confirmed => Fix Committed

-- 
grouphomepage and dashboard  views don't use themes, but can be set
https://bugs.launchpad.net/bugs/619284
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: Fix Committed

Bug description:
When editing a grouphomepage or a dashboard view type, you can set the theme for the view, but when viewing the group/homepage, the theme isn't used.

Options are:
a) Don't allow them to choose the theme; or
b) Have the relevant pages respect themes.

Option a is obviously pretty easy by modifying view/blocks.php to only assign viewthemes if the view isn't in array('grouphomepage', 'dashboard'),
Option b may be preferable long term.