mahara-contributors team mailing list archive

[Andrew Robert Nicols <631278@xxxxxxxxxxxxxxxxxx>]

Having real trouble actually replicating this bug - the link in the
e-mail only takes you to the profile page, and since friendship has
already been established, I don't see the 1 Pending friend request.

Alpha - Chrome
Bravo - Firefox
Charlie - Not logged in

Alpha Requests friendship with Bravo
Bravo accepts friendship with Alpha
Bravo writes on Alpha's wall
Alpha requests friendship with Charlie
Bravo clicks on link in Charlie's e-mail (http://mahara.local/user/view.php?id=3)
--- No pending user request

As a result, I can't reproduce the rest of the bug either.

However, a potential fix could be:
get_record_sql from usr_friend matching the two users
-> if match found, delete any pending requests for between these users and redirect as normal adding the normal OK message (or alternatively telling them that they're already friends).
-> match not found - continue


** Bug watch added: mahara.local/user/ #3
   http://mahara.local/user/view.php?id=3

** Changed in: mahara
     Assignee: Andrew Robert Nicols (dobedobedoh) => (unassigned)

-- 
friend request issues (with two similar accounts)
https://bugs.launchpad.net/bugs/631278
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: Triaged

Bug description:
Charlie and I had a bit of trouble with friend requests on master.dev.

Here's the timeline of the events:

1. Charlie sends friend request to Kristina (member of Mahoodle).
2. Kristina accepts friend request and leaves browser window (FF 3.6 on Mac 10.6) open (and sends a wall message to Charlie as well)
3. Charlie sends friend request to Kristina DC (admin on master.dev)
4. real Kristina clicks on link in email and sees the friend request in Mahara BUT while still logged in as Kristina (and not Kristina DC). It says "1 pending friend" there despite it being the request for Kristina DC
5. Kristina tries to approve friend request but gets error message: "Mahara: Master Branch: Site unavailable. A nonrecoverable error occured. This probably means you have encountered a bug in the system."
6. Kristina tries to deny friend request and succeeds.
7. Charlie receives friend denial from Kristina, but is still friends with Kristina on master.dev as that was the denial for the friend request for Kristina DC
8. real Kristina logs into Mahara as Kristina DC and sees friend request from Charlie
9. Kristina DC can accept friend request without problems