mahara-contributors team mailing list archive

[Richard Mansfield <628921@xxxxxxxxxxxxxxxxxx>]

** Changed in: mahara
       Status: Fix Committed => Fix Released

-- 
1.2.5 -> 1.3.0 Upgrade gives php warnings
https://bugs.launchpad.net/bugs/628921
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: Fix Released

Bug description:
Testing everything I can thinking of under the sun before 1.3 release.
git co 1.2.5_RELEASE
install mahara
git co master
upgrade mahara

Results in the following errors:

[Thu Sep 02 16:33:14 2010] [error] [client 192.168.254.230] [WAR] a6 (lib/db/upgrade.php:1907) Invalid argument supplied for foreach(), referer: http://mahara.local/admin/upgrade.php
[Thu Sep 02 16:33:14 2010] [error] [client 192.168.254.230] Call stack (most recent first):, referer: http://mahara.local/admin/upgrade.php
[Thu Sep 02 16:33:14 2010] [error] [client 192.168.254.230]   * log_message("Invalid argument supplied for foreach()", 8, true, true, "/home/nicols/mahara/htdocs/lib/db/upgrade.php", 1907) at /home/nicols/mahara/htdocs/lib/errors.php:444, referer: http://mahara.local/admin/upgrade.php
[Thu Sep 02 16:33:14 2010] [error] [client 192.168.254.230]   * error(2, "Invalid argument supplied for foreach()", "/home/nicols/mahara/htdocs/lib/db/upgrade.php", 1907, array(size 26)) at /home/nicols/mahara/htdocs/lib/db/upgrade.php:1907, referer: http://mahara.local/admin/upgrade.php
[Thu Sep 02 16:33:14 2010] [error] [client 192.168.254.230]   * xmldb_core_upgrade("2009111015") at /home/nicols/mahara/htdocs/lib/upgrade.php:301, referer: http://mahara.local/admin/upgrade.php
[Thu Sep 02 16:33:14 2010] [error] [client 192.168.254.230]   * upgrade_core(object(stdClass)) at /home/nicols/mahara/htdocs/admin/upgrade.json.php:93, referer: http://mahara.local/admin/upgrade.php
[Thu Sep 02 16:33:14 2010] [error] [client 192.168.254.230] , referer: http://mahara.local/admin/upgrade.php
[Thu Sep 02 16:33:15 2010] [error] [client 192.168.254.230] [WAR] a6 (lib/db/upgrade.php:2032) Invalid argument supplied for foreach(), referer: http://mahara.local/admin/upgrade.php
[Thu Sep 02 16:33:15 2010] [error] [client 192.168.254.230] Call stack (most recent first):, referer: http://mahara.local/admin/upgrade.php
[Thu Sep 02 16:33:15 2010] [error] [client 192.168.254.230]   * log_message("Invalid argument supplied for foreach()", 8, true, true, "/home/nicols/mahara/htdocs/lib/db/upgrade.php", 2032) at /home/nicols/mahara/htdocs/lib/errors.php:444, referer: http://mahara.local/admin/upgrade.php
[Thu Sep 02 16:33:15 2010] [error] [client 192.168.254.230]   * error(2, "Invalid argument supplied for foreach()", "/home/nicols/mahara/htdocs/lib/db/upgrade.php", 2032, array(size 29)) at /home/nicols/mahara/htdocs/lib/db/upgrade.php:2032, referer: http://mahara.local/admin/upgrade.php
[Thu Sep 02 16:33:15 2010] [error] [client 192.168.254.230]   * xmldb_core_upgrade("2009111015") at /home/nicols/mahara/htdocs/lib/upgrade.php:301, referer: http://mahara.local/admin/upgrade.php
[Thu Sep 02 16:33:15 2010] [error] [client 192.168.254.230]   * upgrade_core(object(stdClass)) at /home/nicols/mahara/htdocs/admin/upgrade.json.php:93, referer: http://mahara.local/admin/upgrade.php
[Thu Sep 02 16:33:15 2010] [error] [client 192.168.254.230] , referer: http://mahara.local/admin/upgrade.php


Both errors are because I have no groups and no submitted views - which is probably unlikely in a production environment. However, I think we should probably fix these.

Easy fix is to test the value, and if false, set it as an array.