mahara-contributors team mailing list archive

[Richard Mansfield <670546@xxxxxxxxxxxxxxxxxx>]

This seems like a bad bug.  It looks like Mahara forces auth plugins to
use the same function names (validate_config_options,
save_config_options) for plugin configuration and instance
configuration, and then passes different parameters to the function
depending on whether it's doing plugin or instance config.  It only
affects saml, because that's the only auth plugin that has plugin
configuration.

To fix it without breaking any contributed plugins out ther, maybe we
should make the auth instance config stuff in
htdocs/admin/users/addauthority.php check for the existence of
validate_instance_config_options, save_instance_config_options functions
and if they exist, use those instead of validate_config_options,
save_config_options.

Or else just change the names of all auth plugins to use
validate_instance_config_options etc., and just let any contrib auth
plugins break.

-- 
auth saml config form does not work
https://bugs.launchpad.net/bugs/670546
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: New

Bug description:
Trying to use the config form for the auth:saml plugin/extension results in the form submission hanging and this appears in the error log:

PHP Fatal error:  Cannot use object of type Pieform as array in /web/mahara/htdocs/auth/saml/lib.php on line 461, referer: https://example.com/admin/extensions/pluginconfig.php?plugintype=auth&pluginname=saml

I'm using a checkout of the current Master branch, 1.4.0dev.  This problem does not appear to be in the release branches.  I'm running Linux (RedHat CentOS 5) + Postgres.