mahara-contributors team mailing list archive

[Rich Trott <690427@xxxxxxxxxxxxxxxxxx>]

OK, here's a patch for real this time (I hope).  It reads the "as"
parameter to determine the Authenticating Source.  It checks to make
sure the source exists in the simplesamlphp list of valid sources.  If
not, it defaults to "default-sp" which is what is currently hardcoded as
the only valid source.  (This could stand to be improved, but I don't
want to break current behavior.)


** Patch added: "0001-Allow-setting-of-authenticating-source-aka-Service-P.patch"
   https://bugs.launchpad.net/mahara/+bug/690427/+attachment/1766416/+files/0001-Allow-setting-of-authenticating-source-aka-Service-P.patch

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/690427

Title:
  /auth/saml/index.php hardcodes default SP

Status in Mahara ePortfolio:
  New

Bug description:
  Here's a patch to allow a typical scenario where users get to select from multiple Service Providers to log in.  The service provider specified in the "as" parameter is passed to simplesamlphp, but otherwise defaults to default-sp, which is what is hardcoded in the current code.

If this patch gets accepted, the instructions for how to specify multiple SPs should be added to the documentation or the wiki or whatever.  I'd be happy to do that and to provide a sample login.tpl as well.